fix(workflow): update container dimensions on keyboard movement #3043

waleedlatif1 · 2026-01-28T07:16:02Z

Summary

Renamed updateContainerDimensionsDuringDrag to updateContainerDimensionsDuringMove to reflect broader usage
Added handling for position changes in onNodesChange to resize containers when child nodes are moved via keyboard arrows
Containers now stay properly sized when nodes inside them are moved with keyboard navigation

Type of Change

Bug fix

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-01-28T07:16:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
docs	Ready	Preview, Comment	Jan 28, 2026 8:21pm

greptile-apps · 2026-01-28T07:19:51Z

Greptile Overview

Greptile Summary

This PR fixes a bug where containers weren't properly resizing when child nodes were moved using keyboard navigation. The fix renames updateContainerDimensionsDuringDrag to updateContainerDimensionsDuringMove and adds handling in onNodesChange for position changes from keyboard movements.

Key changes:

Added !change.dragging check in onNodesChange to handle keyboard movements while avoiding duplicate calls during mouse drag operations
Function rename reflects its broader usage for both drag and keyboard movement scenarios
Previous thread concern about duplicate calls has been properly addressed

The implementation is clean and follows the existing patterns in the codebase.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is well-scoped, addresses a specific bug, and properly handles the edge case identified in previous review feedback. The !change.dragging check correctly prevents duplicate function calls during drag operations while enabling the desired keyboard movement behavior.
No files require special attention

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx	Renamed function to reflect broader usage and added keyboard movement handling with proper drag detection to avoid duplicate calls

Sequence Diagram

sequenceDiagram
    participant User
    participant ReactFlow
    participant onNodesChange
    participant onNodeDrag
    participant updateContainerDimensionsDuringMove
    participant DisplayNodes

    Note over User,DisplayNodes: Keyboard Movement Scenario
    User->>ReactFlow: Press arrow key to move node
    ReactFlow->>onNodesChange: NodeChange (type: position, dragging: false)
    onNodesChange->>onNodesChange: Apply node changes
    onNodesChange->>onNodesChange: Check if position change && !dragging
    onNodesChange->>updateContainerDimensionsDuringMove: Update container with new position
    updateContainerDimensionsDuringMove->>DisplayNodes: Resize container to fit children

    Note over User,DisplayNodes: Mouse Drag Scenario
    User->>ReactFlow: Drag node with mouse
    ReactFlow->>onNodeDrag: Node drag event
    onNodeDrag->>onNodeDrag: Check if node has parent container
    onNodeDrag->>updateContainerDimensionsDuringMove: Update container with drag position
    updateContainerDimensionsDuringMove->>DisplayNodes: Resize container during drag
    ReactFlow->>onNodesChange: NodeChange (type: position, dragging: true)
    onNodesChange->>onNodesChange: Apply node changes
    onNodesChange->>onNodesChange: Check if position change && !dragging (false, skip)
    Note over onNodesChange,updateContainerDimensionsDuringMove: Duplicate call prevented by !dragging check

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx

waleedlatif1 · 2026-01-28T18:38:39Z

@greptile

Add !change.dragging check to only handle keyboard movements in onNodesChange, since mouse drags are already handled by onNodeDrag.

greptile-apps

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx

Keyboard arrow key movements now call collaborativeBatchUpdatePositions to sync position changes to the backend for persistence and real-time collaboration.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx

…Ds (#3044) * improvement(cmdk): refactor search modal to use cmdk + fix icon SVG IDs * chore: remove unrelated workflow.tsx changes * chore: remove comments * chore: add devtools middleware to search modal store * fix: allow search data re-initialization when permissions change * fix: include keywords in search filter + show service name in tool operations * fix: correct filterBlocks type signature * fix: move generic to function parameter position * fix(mcp): correct event handler type for onInput * perf: always render command palette for instant opening * fix: clear search input when modal reopens

…atibility (#3046) * fix(helm): move rotationPolicy under privateKey for cert-manager compatibility * docs(helm): add reclaimPolicy Retain guidance for production database storage * fix(helm): prevent empty branding ConfigMap creation

Check isInDragOperation before persisting in onNodesChange to prevent duplicate calls. Drag-end events have dragStartPosition still set, while keyboard movements don't, allowing proper distinction.

greptile-apps bot reviewed Jan 28, 2026

View reviewed changes

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx Show resolved Hide resolved

fix(workflow): update container dimensions on keyboard movement

b4f9072

waleedlatif1 force-pushed the fix/keyboard-subflow-movement branch from 5680fa0 to b4f9072 Compare January 28, 2026 18:34

vercel bot temporarily deployed to Preview January 28, 2026 18:34 Inactive

vercel bot temporarily deployed to Preview January 28, 2026 18:37 Inactive

fix(workflow): avoid duplicate container updates during drag

7c0952d

Add !change.dragging check to only handle keyboard movements in onNodesChange, since mouse drags are already handled by onNodeDrag.

waleedlatif1 force-pushed the fix/keyboard-subflow-movement branch from 81cd857 to 7c0952d Compare January 28, 2026 18:39

vercel bot temporarily deployed to Preview January 28, 2026 18:39 Inactive

greptile-apps bot reviewed Jan 28, 2026

View reviewed changes

cursor bot reviewed Jan 28, 2026

View reviewed changes

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx Show resolved Hide resolved

vercel bot temporarily deployed to Preview January 28, 2026 20:02 Inactive

fix(workflow): persist keyboard movements to backend

5e9d9d5

Keyboard arrow key movements now call collaborativeBatchUpdatePositions to sync position changes to the backend for persistence and real-time collaboration.

waleedlatif1 force-pushed the fix/keyboard-subflow-movement branch from f97021f to 5e9d9d5 Compare January 28, 2026 20:02

vercel bot temporarily deployed to Preview January 28, 2026 20:02 Inactive

cursor bot reviewed Jan 28, 2026

View reviewed changes

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx Show resolved Hide resolved

waleedlatif1 added 3 commits January 28, 2026 12:18

fix(workflow): avoid duplicate position updates on drag end

f9c793d

Check isInDragOperation before persisting in onNodesChange to prevent duplicate calls. Drag-end events have dragStartPosition still set, while keyboard movements don't, allowing proper distinction.

waleedlatif1 force-pushed the fix/keyboard-subflow-movement branch from 3f8b1a7 to f9c793d Compare January 28, 2026 20:19

vercel bot temporarily deployed to Preview January 28, 2026 20:19 Inactive

waleedlatif1 merged commit 2c2b485 into staging Jan 28, 2026
12 checks passed

waleedlatif1 deleted the fix/keyboard-subflow-movement branch January 28, 2026 20:31

waleedlatif1 mentioned this pull request Jan 29, 2026

v0.5.75: search modal overhaul, helm chart updates, run from block, terminal and visual debugging improvements #3058

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workflow): update container dimensions on keyboard movement #3043

fix(workflow): update container dimensions on keyboard movement #3043

Uh oh!

waleedlatif1 commented Jan 28, 2026

Uh oh!

vercel bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

waleedlatif1 commented Jan 28, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(workflow): update container dimensions on keyboard movement #3043

fix(workflow): update container dimensions on keyboard movement #3043

Uh oh!

Conversation

waleedlatif1 commented Jan 28, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Jan 28, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 28, 2026 •

edited

Loading

greptile-apps bot commented Jan 28, 2026 •

edited

Loading